[9.x] Makes database factories generic #39169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the public methods ( and not protected ) of the database factory class generic. In other words, it allows to get auto-completion like this:
Note that, to get this flavor people need to add this annotation to the top of their existing database factory classes. New database factory classes, created from
php artisan make:factory
already include this annotation.For people who opt for not using this annotation, the auto-completion still works, but on the base model class:
PHPStan wise is still not perfect, as we need the
\Illuminate\Database\Eloquent\Model|TModel
union is needed to make PHPStorm understand that\Illuminate\Database\Eloquent\Model
is the default generic type of TModel.If this pull request gets merged, I will update the
UserFactory
class in our skeletons.